Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for creating custom static routes #726

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Add support for creating custom static routes #726

merged 4 commits into from
Dec 19, 2024

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Dec 19, 2024 •
edited
Loading

Overview/Summary

Closes #725

This PR fixes/adds/changes/removes

  1. Adds a new deployment parameter customStaticRoutes that can be used to specify additional routes, e.g., to reach domain controllers.
  2. Merges the value of the new parameter with the static routes applied to the AVD subnet.

Breaking Changes

N/A

Testing Evidence

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@SvenAelterman
Copy link
Contributor Author

Note: this PR might create a merge conflict after merging #724 because I fixed a typo in the same file there. I'll update the PR after #724 is merged.

@danycontre danycontre merged commit 69403f3 into Azure:main Dec 19, 2024
8 checks passed
@danycontre
Copy link
Collaborator

Thanks @SvenAelterman PR merged, we are fixing the conflicts.

If you have the time please add the custom route option to the portal UI under the networking tab.

@SvenAelterman
Copy link
Contributor Author

If you have the time please add the custom route option to the portal UI under the networking tab.

I will think how we could present that usefully in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danycontre danycontre danycontre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide support for additional static routes on AVD subnet
2 participants
@SvenAelterman @danycontre